Re: gc-pbkdf2-sha1 is deprecated

[Bruce Korb]

Hi Bruno, et al.,

The failing difference isn't whether or not I use gc_pbkdf2_hmac vs. 
gc_pbkdf2_sha1, the failing difference is whether or not I specify the 
crypto/gc-pbkdf2-sha1 module vs. the crypto/gc-pbkdf2 module. The former 
works, the latter does not, with the rest of my project entirely 
unchanged. Feel free to test it, assuming you have the autogen suite for 
bootstrapping:

[remote "origin"]
        url = bkorb@git.savannah.gnu.org:/srv/git/gnu-pw-mgr.git

Without specifying the "-sha1" module, the make check fails with the 
pbkdf2 function returning 5. Here's the patch that causes the project to 
fail:

diff --git a/bootstrap.conf b/bootstrap.conf
index b0e397a..7703c6f 100755
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -90,7 +90,7 @@ initialize() {
     gnulib_modules='
         base64              \
         close               \
-        crypto/gc-pbkdf2-sha1 \
+        crypto/gc-pbkdf2      \
         crypto/gc-random    \
         crypto/sha256       \
         ctype               \

and it yields this error message:

+++T=gpw-53> /u/bkorb/tools/gnu-pw-mgr-bld/src/gnu-pw-mgr 
--config-file=/tmp/gpw-3tsXGB/.local/gnupwmgr.cfg --rehash=1 -i test-tag who
gnu-pw-mgr fatal error:
gc_pbkdf2_sha1 returned error code 5

On 9/21/20 3:49 PM, Bruce Korb wrote:
> > It may go away, because the module crypto/gc-pbkdf2 contains more 
> > generic API to do the same thing: gc_pbkdf2_hmac with first argument 
> > GC_SHA1.
> >
> > Bruno