Re: nap() name space clash

[Tim Rice]

[reviving an old thread that started here
https://lists.gnu.org/archive/html/bug-gnulib/2020-02/msg00025.html]

Hi Bruno,

On Thu, 6 Feb 2020, Tim Rice wrote:

> On Wed, 5 Feb 2020, Bruno Haible wrote:
> 
> } Hi Tim,
> } 
> } > > > I discoverd a name space clash with nap()
> } > > 
> } > > In which .h file is this function declared on UnixWare?
> } > 
> } > unistd.h
> } 
> } Can you find out whether defining some preprocessor symbol will make
> } the declaration disappear?
> 
> There are 3. Any one of them would make the declaration disappear
> but also disappear 27 other declarations and 5 defines.
> Not really a viable option.
> 
> Since the usage of nap() is in the gnulib test framework I would think the
> chances of other consumers of nap() would be very small so renaming that
> function in gnulib would have minimal impact. (the 8 files mentioned before)
> Now if we choose to rename map.h, these additional files would need changes.
> tests/test-utimens-common.h
> modules/chown-tests
> modules/futimens-tests
> modules/utime-tests
> modules/lchown-tests
> modules/utimens-tests
> modules/fdutimensat-tests
> modules/utimensat-tests
> modules/fchownat-tests
> modules/stat-time-tests
> 
> } The right form should be doc/Copyright/request-assign.future (in the gnulib
> } repository).
> 
> Filled out and e-mailed in.
> 
> } 
> } Bruno
> } 

Now with copyright papers in place and some time to get back to this,
I've prepared 2 patch options for your consideration.

The attached nap2gnulib_nap.patch renames nap to gnulib_nap and leaves
the tests/nap.h name alone.

The attached nap2gnulib_nap_with_nap_h_rename.patch assumes a
"git mv tests/nap.h tests/gnulib_nap.h"

I did a little digging ad discovered that nap() in libc goes back to
at least Xenix 286 as discussed in this article.
http://wdb1.sco.com/kb/showta?taid=100218

Thanks for your consideration.

-- 
Tim Rice                                Multitalents
tim@multitalents.net

nap2gnulib_nap.patch
Description: nap2gnulib_nap.patch

nap2gnulib_nap_with_nap_h_rename.patch
Description: nap2gnulib_nap_with_nap_h_rename.patch