Re: clang warnings in regcomp.c

[Bruno Haible]

Paul Eggert wrote:
> > What is the point of these parentheses?
> 
> Haven't a clue. It's an unusual style.
> 
> >   static reg_errcode_t preorder (bin_tree_t *root,
> > -                          reg_errcode_t (fn (void *, bin_tree_t *)),
> > +                          reg_errcode_t fn (void *, bin_tree_t *),
> >                            void *extra);
> 
> For corrections like that I suggest the style "reg_errcode_t (*fn) (void *, 
> bin_tree_t *)" instead, as that's the usual style in glibc and I expect it is 
> the style that was intended in regcomp.c anyway.

Thanks for the advice. I reported it on the glibc tracker:
https://sourceware.org/bugzilla/show_bug.cgi?id=26725

Bruno