[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: test-verify.c: avoid -Wmissing-declarations warnings
From: |
Bernhard Voelker |
Subject: |
Re: test-verify.c: avoid -Wmissing-declarations warnings |
Date: |
Mon, 2 Nov 2020 01:50:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 10/31/20 12:46 PM, Bruno Haible wrote:
> Bernhard Voelker wrote:
>> I noticed a new build failure in coreutils when configuring with
>> --enable-gcc-warnings.
>> GCC is 10.2.1.
>> Fixed with the attached.
>
> While Gnulib generally doesn't support compiling with '-Werror' — this is the
> option that makes your build fail —, I see no reason to reject your patch.
Thanks.
Re. -Werror use: coreutils enables --enable-gcc-warnings per default in
maintainer mode, i.e., if building from the Git repository.
This works really well like that since several years now.
> Applied, with just a tweak in the first line of the commit message.
> If possible, we like it to be in the form
> <module name>: <summary>
Okay thanks. I just did it like that by almost copying Jim's previous
patch: <https://git.sv.gnu.org/cgit/gnulib.git/commit/?id=40518bb8dee>
Have a nice day,
Berny