bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] read-file: remove dead assignment


From: Daiki Ueno
Subject: [PATCH] read-file: remove dead assignment
Date: Sat, 21 Nov 2020 17:40:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>From 69b8df2c5b011b09c8d03c13566356a906bd89dc Mon Sep 17 00:00:00 2001
From: Daiki Ueno <ueno@gnu.org>
Date: Sat, 21 Nov 2020 17:32:58 +0100
Subject: [PATCH] read-file: remove dead assignment

* lib/read-file.c (fread_file): Remove dead assignment when
RF_SENSITIVE is set, flagged by clang-analyzer.
---
 ChangeLog       | 6 ++++++
 lib/read-file.c | 1 -
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 64be77149..95d40a496 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2020-11-21  Daiki Ueno  <ueno@gnu.org>
+
+       read-file: remove dead assignment
+       * lib/read-file.c (fread_file): Remove dead assignment when
+       RF_SENSITIVE is set, flagged by clang-analyzer.
+
 2020-11-19  Akim Demaille  <akim@lrde.epita.fr>
 
        bitset: tests: exercise the stats too
diff --git a/lib/read-file.c b/lib/read-file.c
index 88bc0070a..be93a7e09 100644
--- a/lib/read-file.c
+++ b/lib/read-file.c
@@ -156,7 +156,6 @@ fread_file (FILE *stream, int flags, size_t *length)
               memcpy (new_buf, buf, save_alloc);
               explicit_bzero (buf, save_alloc);
               free (buf);
-              buf = new_buf;
             }
           else if (!(new_buf = realloc (buf, alloc)))
             {
-- 
2.26.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]