Re: [PATCH 2/6] canonicalize: fix EOVERFLOW bug

[Bruno Haible]

Hi Paul,

>  2020-12-02  Paul Eggert  <eggert@cs.ucla.edu>
>  
> +     canonicalize: fix EOVERFLOW bug
> +     * lib/canonicalize.c (canonicalize_filename_mode):
> +     When testing whether a directory entry is a symbolic link, or a
> +     directory or other, do not use lstat or stat or
> +     areadlink_with_size.  Just use areadlink, as this suffices and it
> +     avoids the EOVERFLOW problem that lstat and stat have.
> +     * modules/canonicalize (Depends-on): Depend on areadlink instead
> +     of areadlink-with-size and stat.

This patch introduced a unit test regression on AIX 7.2.
Reproducible on gcc119.fsffrance.org both in 32-bit and 64-bit mode
through

$ git checkout 47f74ead5c1cb72d489ea06a8a716eb0f65a430c
$ rm -rf ../testdir-canon4; ./gnulib-tool --create-testdir 
--dir=../testdir-canon4 --single-configure canonicalize
and running testdir-canon4 on this machine.

Details:
../../gltests/test-canonicalize.c:112: assertion 'result1 == NULL' failed
FAIL test-canonicalize (exit status: 134)

Bruno