[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath
|
From: |
Adhemerval Zanella |
|
Subject: |
Re: [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath |
|
Date: |
Mon, 28 Dec 2020 18:50:59 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 28/12/2020 18:14, Paul Eggert wrote:
> On 12/28/20 5:59 AM, Adhemerval Zanella wrote:
>> The faccessat (..., AT_EACCESS) on Linux fallback will either use
>> __NR_faccessat for __libc_enable_secure or LFS fstatat call. Neither
>> fallbacks returns EOVERFLOW in failure case.
> Argh, I had misread the glibc source code in this area. So I installed this
> further Gnulib patch:
>
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=d82dfeb8a7c9b276c8c7db94d077eb7a43a6760c
>
> which should result in even simpler code than the v2 6/6 patch.
>
> So, to summarize this series of 6 patches to glibc:
>
> * Patches 1, 2, and 3 are fine.
>
> * Patch 4 (stdlib: Sync canonicalize with gnulib) can now sync with today's
> Gnulib instead.
>
> * Patch 5 and 6 are no longer needed, since today's Gnulib subsumes them.
Right, I will sort this out and push a version synced with gnulib master.
I forgot to send a testcase for BZ#26341, which I will push as well.
Thanks for working on this to accommodate both gnulib and glibc requirements.
- [PATCH v2 1/6] Import idx.h from gnulib, Adhemerval Zanella, 2020/12/28
- [PATCH v2 2/6] Import filename.h from gnulib, Adhemerval Zanella, 2020/12/28
- [PATCH v2 3/6] malloc: Add scratch_buffer_dupfree, Adhemerval Zanella, 2020/12/28
- [PATCH v2 5/6] stdlibc: Simplify realpath via scratch_buffer_dupfree, Adhemerval Zanella, 2020/12/28
- [PATCH v2 4/6] stdlib: Sync canonicalize with gnulib [BZ #10635] [BZ #26592] [BZ #26341] [BZ #24970], Adhemerval Zanella, 2020/12/28
- [PATCH v2 6/6] stdlib: Assume FACCESSAT_NEVER_EOVERFLOWS on realpath, Adhemerval Zanella, 2020/12/28