Re: [PATCH] Merge glibc ieee128 ldbl redirect support into cdefs.h

[Paul Eggert]

On 1/4/21 7:28 PM, Bruno Haible wrote:
> Yes, there is the potential for redefinition warnings here. If they occur,
> we should consider where in the compilation unit to include standard headers
> like <stdio.h> and where to include <libc-config.h>. And maybe add a header
> <libc-config-end.h> which undefines all of <libc-config.h> ?

I'm hoping we don't need to go down that path, as I want to minimize 
differences from glibc. We've talked glibc into putting this into glibc 
source files:

#ifndef _LIBC
# include <libc-config.h>
#endif

and I'd rather not have to talk glibc into putting more stuff like that 
in, if it can be avoided.

I think I see a way to do that: include glibc <cdefs.h> only on 
platforms where <sys/cdefs.h> is not good enough for Gnulib. This should 
give us some time to update our cdefs.h after Glibc does. Had we done 
this before, we would have had eight years grace period instead of no 
years. I installed the attached patch to try to do that. A good chunk of 
it is simple reindenting, and you can use "git diff -w" to narrow it down.

0001-libc-config-merge-from-glibc.patch
Description: Text Data