[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: syntax-checks with names containing the letter w not invoked
From: |
Simon Josefsson |
Subject: |
Re: syntax-checks with names containing the letter w not invoked |
Date: |
Wed, 06 Jan 2021 12:39:52 +0100 |
User-agent: |
Evolution 3.30.5-1.1 |
tis 2021-01-05 klockan 12:52 -0800 skrev Jim Meyering:
> On Mon, Jan 4, 2021 at 2:44 PM Jim Meyering <jim@meyering.net> wrote:
> > On Mon, Jan 4, 2021 at 2:22 PM Simon Josefsson via Gnulib
> > discussion
> > list <bug-gnulib@gnu.org> wrote:
> > > Hi. I noticed that 'make syntax-check' never ran syntax checks
> > > whose
> > > name contained 'w' on my local machine, but did so on CICD
> > > builds. I
> > > tracked it down due to this:
> > >
> > > jas@latte:~/src/gsasl$ echo $LANG
> > > sv_SE.UTF-8
> > > jas@latte:~/src/gsasl$ echo foowbar: | sed -n 's/^\([a-
> > > z]*\):/\1/p'
> > > jas@latte:~/src/gsasl$ echo foowbar: | LANG=C sed -n 's/^\([a-
> > > z]*\):/\1/p'
> > > foowbar
> > > jas@latte:~/src/gsasl$
> > >
> > > The following patch (installed) fixes this for me, although I
> > > suspect
> > > other uses in maint.mk may be affected too.
> >
> > Hi Simon.
> > Happy new year.
> > Good catch. We're probably ready to start using character classes
> > like
> > [:alnum:], but it's better to fix this to use LC_ALL=C for now.
> > I.e.,
> > please use LC_ALL=C, not LANG=C in that patch.
>
> I see you pushed that change, so I've pushed the correction.
Thank you Jim. Happy new year :)
/Simon
signature.asc
Description: This is a digitally signed message part