bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/7] zerosize-ptr: Fix compilation on OS/2 kLIBC


From: KO Myung-Hun
Subject: Re: [PATCH 5/7] zerosize-ptr: Fix compilation on OS/2 kLIBC
Date: Fri, 22 Jan 2021 23:26:37 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Hi/2.

Bruno Haible wrote:
> Applied with modifications:
>> -#if HAVE_SYS_MMAN_H && HAVE_MPROTECT
>> +#if HAVE_SYS_MMAN_H && HAVE_MPROTECT && (!defined __KLIBC__ || HAVE_MMAP)
> 
> There's a comment two lines above, that explains why HAVE_MMAP is not
> the right test here. And since you write "OS/2 kLIBC has <sys/mman.h>
> and mprotect() but not mmap()", defined __KLIBC__ implies !HAVE_MMAP.
> 

I saw that. So I tested HAVE_MMAP only on kLIBC. Anyway I agree that
just defined __KLIBC__ is enough.

Thanks!

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]