Re: [PATCH] maintainer-makefile: Mimic bootstrap's gnulib-srcdir guessing.

[Simon Josefsson]

Bruno Haible <bruno@clisp.org> writes:

> Hi Simon,
>
>> The reason is top/maint.mk has
>> 
>>  # You can override this variable in cfg.mk if your gnulib submodule lives
>>  # in a different location.
>>  gnulib_dir ?= $(srcdir)/gnulib
>> 
>> and that directory doesn't exist if bootstrap used $GNULIB_SRCDIR.
>
> Instead of relying on an environment variable, I would find it more reliable
> to rely on the contents of the '.gitmodules' files. Like top/gitsub.sh does
> it.

See the beginning of my e-mail:

 Hi!  I've noticed in a couple of projects that use bootstrap, without a
                                                               ^^^^^^^^^
 gnulib git submodule, and where $GNULIB_SRCDIR is set during bootstrap,
 ^^^^^^^^^^^^^^^^^^^^
 that syntax-check will print some spurious errors like this:

So this is for projects that do not have a git submodule.  There is no
requirement to use git submodules for bootstrap or gnulib-tool, is
there?  My preference is that git submodule is a pain.  Lately I made a
pre-release for GNU InetUtils that has been using bootstrap for years
without a git submodule.  Several other projects are using gnulib in
various ways without git submodules.

/Simon

signature.asc
Description: PGP signature