>From 5886f0967c83e27bf4cccfef13a1528195e3651a Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sun, 3 Jan 2021 20:46:04 +0100 Subject: [PATCH 3/3] iconv, iconv_open: Improve documentation. Reported by Noah Misch in . * doc/posix-functions/iconv_open.texi: Add new paragraph "Portability problems handled by Gnulib". * doc/posix-functions/iconv.texi: Likewise. Update info about AIX. * m4/iconv.m4 (AM_ICONV_LINK): Improve comments. --- ChangeLog | 10 ++++++++++ doc/posix-functions/iconv.texi | 8 +++++++- doc/posix-functions/iconv_open.texi | 6 ++++++ m4/iconv.m4 | 7 ++++--- 4 files changed, 27 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4b9f083..6c042f5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,15 @@ 2021-01-03 Bruno Haible + iconv, iconv_open: Improve documentation. + Reported by Noah Misch in + . + * doc/posix-functions/iconv_open.texi: Add new paragraph "Portability + problems handled by Gnulib". + * doc/posix-functions/iconv.texi: Likewise. Update info about AIX. + * m4/iconv.m4 (AM_ICONV_LINK): Improve comments. + +2021-01-03 Bruno Haible + iconv-h: Fix module description. * modules/iconv-h (Include): Check HAVE_ICONV_H. diff --git a/doc/posix-functions/iconv.texi b/doc/posix-functions/iconv.texi index 01e7fd1..4e1c182 100644 --- a/doc/posix-functions/iconv.texi +++ b/doc/posix-functions/iconv.texi @@ -10,9 +10,15 @@ Portability problems fixed by Gnulib: @itemize @item GNU libiconv is not found if installed in @file{$PREFIX/lib}. +@end itemize + +Portability problems handled by Gnulib +(in the sense that @code{HAVE_ICONV} does not get defined if the system's +@code{iconv} function has this problem): +@itemize @item Failures are not distinguishable from successful returns on some platforms: -AIX 5.1, Solaris 10. +AIX 5.1..7.2, Solaris 10. @item A buffer overrun can occur on some platforms: AIX 6.1..7.1. diff --git a/doc/posix-functions/iconv_open.texi b/doc/posix-functions/iconv_open.texi index f46cf98..98f22ae 100644 --- a/doc/posix-functions/iconv_open.texi +++ b/doc/posix-functions/iconv_open.texi @@ -10,6 +10,12 @@ Portability problems fixed by either Gnulib module @code{iconv} or @code{iconv_o @itemize @item GNU libiconv is not found if installed in @file{$PREFIX/lib}. +@end itemize + +Portability problems handled by either Gnulib module @code{iconv} or @code{iconv_open} +(in the sense that @code{HAVE_ICONV} does not get defined if the system's +@code{iconv_open} function has this problem): +@itemize @item No converter from EUC-JP to UTF-8 is provided on some platforms: HP-UX 11. diff --git a/m4/iconv.m4 b/m4/iconv.m4 index 04e3bad..d0e61de 100644 --- a/m4/iconv.m4 +++ b/m4/iconv.m4 @@ -1,4 +1,4 @@ -# iconv.m4 serial 23 +# iconv.m4 serial 24 dnl Copyright (C) 2000-2002, 2007-2014, 2016-2021 Free Software Foundation, dnl Inc. dnl This file is free software; the Free Software Foundation @@ -92,8 +92,9 @@ AC_DEFUN([AM_ICONV_LINK], #endif ]], [[int result = 0; - /* Test against AIX 5.1 bug: Failures are not distinguishable from successful - returns. */ + /* Test against AIX 5.1...7.2 bug: Failures are not distinguishable from + successful returns. This is even documented in + */ { iconv_t cd_utf8_to_88591 = iconv_open ("ISO8859-1", "UTF-8"); if (cd_utf8_to_88591 != (iconv_t)(-1)) -- 2.7.4