[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] realloc: fix undef typo

From: Paul Eggert
Subject: Re: [PATCH] realloc: fix undef typo
Date: Sun, 11 Apr 2021 12:38:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/10/21 3:22 PM, Bruno Haible wrote:
The patch above has the effect that libunistring.so will now export
'realloc'. Which is not right.

OK, but why doesn't a similar problem happen with malloc and calloc? lib/malloc.c has "#undef malloc", and similarly for lib/calloc.c.

I doubt there are many packages that still use AC_FUNC_REALLOC the
"old" way, without gnulib. (Maybe gawk still does?)

No, Gawk doesn't use AC_FUNC_REALLOC or Gnulib lib/realloc.c. Similarly for calloc and malloc.

Perhaps we should simply remove the "#ifdef malloc" section from lib/malloc.c, and similar for calloc and realloc.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]