[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] make gl_VISIBILITY to reject unsupported configurations with
Re: [PATCH] make gl_VISIBILITY to reject unsupported configurations with newer gcc
Wed, 26 May 2021 03:34:53 +0300
>> The attached patch makes gl_VISIBILITY to reject unsupported configurations
>> with newer gcc: In its current form, mingw gcc-4.5.4 rejects the attributes
>> but gcc-7.5 does not, apparently because the attributes are applied to func
>> prototypes without their definitions. Attaching a hidden visibility attrib
>> to dummyfunc() makes gcc-7.5 to reject it properly.
> I don't fully understand why we should apply the patch.
> With gcc 7.5 on mingw and the visibility.m4 that is in gnulib now:
> What is the result of the
> checking for simple visibility declarations...
> test? What are the effects: warnings? compilation errors? link errors? too
> many exported symbols? too few exported symbols?
No warnings from the testcase in m4. In real-life, it results in warnings,
see e.g.: https://github.com/libsndfile/libsamplerate/issues/154
> Maybe you also have a test case, that you could show?
The above bug report should cover it I think. If not, tell me.