bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] regex: pacify GCC 11.2 -fanalyzer


From: Paul Eggert
Subject: [PATCH] regex: pacify GCC 11.2 -fanalyzer
Date: Sat, 31 Jul 2021 13:32:47 -0700

* lib/regex_internal.c (re_node_set_insert):
Add a debug assertion to pacify GCC 11.2 -fanalyzer.
---
 ChangeLog            | 4 ++++
 lib/regex_internal.c | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 80bcabd22..e3b868f91 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2021-07-31  Paul Eggert  <eggert@cs.ucla.edu>
 
+       regex: pacify GCC 11.2 -fanalyzer
+       * lib/regex_internal.c (re_node_set_insert):
+       Add a debug assertion to pacify GCC 11.2 -fanalyzer.
+
        maint: pacify GCC 11.2 -fanalyzer in crypto tests
        * tests/bench-digest.h (main): Report an error after memory
        exhaustion, instead of using a null pointer.
diff --git a/lib/regex_internal.c b/lib/regex_internal.c
index 55f6b66de..6f755b214 100644
--- a/lib/regex_internal.c
+++ b/lib/regex_internal.c
@@ -1286,7 +1286,10 @@ re_node_set_insert (re_node_set *set, Idx elem)
 
   if (__glibc_unlikely (set->nelem) == 0)
     {
-      /* We already guaranteed above that set->alloc != 0.  */
+      /* Although we already guaranteed above that set->alloc != 0 and
+         therefore set->elems != NULL, add a debug assertion to pacify
+         GCC 11.2 -fanalyzer.  */
+      DEBUG_ASSERT (set->elems);
       set->elems[0] = elem;
       ++set->nelem;
       return true;
-- 
2.31.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]