[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] lib/regexec: Resolve unused variable

From: Paul Eggert
Subject: Re: [PATCH 3/3] lib/regexec: Resolve unused variable
Date: Wed, 11 Aug 2021 00:24:25 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 6/18/21 8:44 AM, Darren Kenny wrote:
The reason for this issue is that we are not building with DEBUG set and
this in turn means that the assert() that reads the value of the
variable match_last is being processed out.

Unfortunately I don't understand the scenario here. If not building with DEBUG, 'DEBUG_ASSERT (match_last != 1)' should expand to 'assume (match_last != 1)', which in turn should expand to something that evaluates the expression 'match_last != 1'. Please see this commit, which removed the "#ifdef" that you're proposing to re-add:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]