[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test-driver patch?

From: Bruno Haible
Subject: Re: test-driver patch?
Date: Sun, 05 Sep 2021 12:19:26 +0200

Hi Simon,

> parallel-tests: installing '../build-aux/test-driver'
> patching file build-aux/test-driver
> Hunk #1 FAILED at 109.
> 1 out of 1 hunk FAILED -- saving rejects to file build-aux/test-driver.rej
> patching file build-aux/test-driver

A different patch is needed for Automake version ≤ 1.16.3 than for
Automake 1.16.4. gnulib-tool tried both patches in turn and thus did the
right thing.

> The test-driver patching stuff seems a bit fragile, I'm not sure how to best
> fix this.  Ideas?

To me, it's merely a perception problem. We could silence the first patch

It would be possible to apply a 'sed' transformation rather than a patch,
if we make sure to do it in a robust way, i.e. bail out if the transformation
did not find the expected pattern. Although, I prefer 'patch' because it's
more general than 'sed'.

Or maybe upstream the change? Would it be OK for _all_ projects that use
Automake to assume that test files whose name end in '.sh' are supposed
to be invoked through 'sh'?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]