bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] glob: resolve DT_UNKNOWN via is_dir


From: DJ Delorie
Subject: Re: [patch] glob: resolve DT_UNKNOWN via is_dir
Date: Wed, 17 Nov 2021 16:59:41 -0500

Florian Weimer <fweimer@redhat.com> writes:
>> +                  if (fullpath == NULL)
>> +                    /* This matches old behavior wrt DT_UNKNOWN.  */
>> +                    break;
>
> Shouldn't this report memory allocation failure to the caller?

We could easily replace that break with a "goto memory_error" but that
changes the new logic from "better hint" to "mandatory function".




reply via email to

[Prev in Thread] Current Thread [Next in Thread]