[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] glob: resolve DT_UNKNOWN via is_dir

From: Florian Weimer
Subject: Re: [patch] glob: resolve DT_UNKNOWN via is_dir
Date: Wed, 17 Nov 2021 23:14:02 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>>> +                 if (fullpath == NULL)
>>> +                   /* This matches old behavior wrt DT_UNKNOWN.  */
>>> +                   break;
>> Shouldn't this report memory allocation failure to the caller?
> We could easily replace that break with a "goto memory_error" but that
> changes the new logic from "better hint" to "mandatory function".

I thought the bug is that it's not actually a hint?  That DT_UNKNOWN
here leads to incorrect results in glob?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]