Re: [patch] glob: resolve DT_UNKNOWN via is_dir

[Florian Weimer]

* DJ Delorie:

> Florian Weimer <fweimer@redhat.com> writes:
>>> +                 if (fullpath == NULL)
>>> +                   /* This matches old behavior wrt DT_UNKNOWN.  */
>>> +                   break;
>>
>> Shouldn't this report memory allocation failure to the caller?
>
> We could easily replace that break with a "goto memory_error" but that
> changes the new logic from "better hint" to "mandatory function".

I thought the bug is that it's not actually a hint?  That DT_UNKNOWN
here leads to incorrect results in glob?

Thanks,
Florian