Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

[Fabrice Fontaine]

Le mar. 30 nov. 2021 à 22:00, Paul Eggert <eggert@cs.ucla.edu> a écrit :
>
> On 11/30/21 09:29, Fabrice Fontaine wrote:
> >
> > +#include <stddef.h>
> >   #include <sys/random.h>
>
> This surely isn't the right fix, as <sys/random.h> is supposed to
> include <stddef.h> on uClibc. See gnulib/lib/sys_random.in.h's comment
> about uClibc. Could you investigate why that part of sys/random.h isn't
> working on your platform?
Thanks for spotting my mistake. Indeed, the issue should have been
fixed since August 2020 by commit
4e082bffbcc46e68644ae0d59b4f09bf2b5feb84.
However, this doesn't work because features.h is not included before
checking for __UCLIBC__.
As a result, __UCLIBC__ is never defined and stddef.h is not included.
Should I send a new patch ?