[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()

From: Robbie Harwood
Subject: Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()
Date: Tue, 07 Dec 2021 13:51:04 -0500

Paul Eggert <eggert@cs.ucla.edu> writes:

> On 12/1/21 19:20, Paul Eggert wrote:
>> On 12/1/21 13:02, Robbie Harwood wrote:
>>> @@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
>>>       }
>>>       break;
>>>         default:
>>> -    abort ();
>>> +    break;
>>>         }
>> Likewise, it's not clear why this change is needed. The 'abort' should 
>> not be reachable.
>> Is the intent to make the code a bit smaller by avoding calls to 'abort'? 
> A followup idea: would it help to replace 'abort ()' with 'DEBUG_ASSERT 
> (false)', or to replace 'if (!X) abort ();' with 'DEBUG_ASSERT (X);'?

Unfortunately Vladimir has not so far been responding to gnulib emails,
However, I don't believe we have an implementation of abort() that can
be called.  (We have grub_abort() instead.)  If that's the correct
reason, then DEBUG_ASSERT would work and I can make that change.

Be well,

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]