[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: makefile rules

From: Paul Eggert
Subject: Re: makefile rules
Date: Wed, 22 Dec 2021 11:02:00 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1

On 12/21/21 12:12, Bruno Haible wrote:
I'm fine with removing these 'rm -f $@-t $@' commands.

OK, I did that with the first attached patch.

The @NMD@ business means we need recipe lines that say "$(AM_V_GEN)" and nothing else. However, this should be portable and GNU Make figures it out without forking more processes.

This also changes "mv -f $@-t $@" to plain "mv $@-t $@". The -f is not needed. Formerly we were inconsistent about whether to use -f and I figured we might as well be simpler.

This patch omits instances of trailing "&& \" when keeping it would contort the code due to the @NMD@s. This is another argument for omitting "&& \" when it's not needed, as discussed in <https://lists.gnu.org/r/bug-gnulib/2021-12/msg00125.html>.

I also installed the second attached patch, which adds a couple of @NMD@s that were missed earlier.

Attachment: 0001-maint-omit-unnecessary-rm-f-t.patch
Description: Text Data

Attachment: 0002-libgmp-omit-redundant-mkdir-p.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]