[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: makefile rules

From: Bruno Haible
Subject: Re: makefile rules
Date: Fri, 24 Dec 2021 13:10:39 +0100

Paul Eggert wrote:
> I haven't installed this patchset into Gnulib, as I want to test it on a 
> few more platforms and also would like to hear comments.


1) In 0001: modules/sed-header should have a section


Like e.g. modules/gperf or modules/snippet/arg-nonnull. Why? See

2) In 0003: The ChangeLog entry says "Put a DO NOT EDIT line at the start,
though." but the code does not do that. The first line of the generated file is
'# TS-start'.

3) In 0004: The ChangeLog entry line

* gnulib-tool (func_emit_lib_Makefile_am): Support @!NMD@ too.

should mention also func_emit_tests_Makefile_am:

* gnulib-tool (func_emit_lib_Makefile_am, func_emit_tests_Makefile_am): Support 
@!NMD@ too.

4) In 0004: The module 'sed-header' is no longer about running 'sed'. It's
more generally about generated header files. How about renaming the module
'sed-header' to 'gen-header'?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]