[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Stack module and -Wsign-compare

From: Paul Eggert
Subject: Re: Stack module and -Wsign-compare
Date: Wed, 5 Jan 2022 11:54:45 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1

On 1/5/22 10:00, Bruno Haible wrote:
Another possible fix would be to change
   size_t size;
   idx_t size;
in the struct.

Yes, that fits better into our strategy of preferring signed to unsigned types for sizes. Plus, it avoids a cast that's too powerful in C. I installed the attached.

Attachment: 0001-stack-pacify-gcc-Wsign-compare.patch
Description: Text Data

Attachment: 0002-stack-also-update-stack_size-to-return-idx_t.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]