[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] copy-file-range: work around Linux kernel bug

From: Pádraig Brady
Subject: Re: [PATCH] copy-file-range: work around Linux kernel bug
Date: Sun, 16 Jan 2022 19:05:18 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0

On 16/01/2022 18:06, Paul Eggert wrote:
On 1/16/22 05:37, Pádraig Brady wrote:
This looks like the replacement will only be used when the build system
uses an older kernel?
If so this seems brittle. Consider the case where el7 rpms are being
built on
central build systems with newer kernels.

It doesn't run any code on the newer kernels, right? It merely compiles.
If the compilation environment says "this is being compiled for kernel
5.3", surely the generated code can assume 5.3 or later.

Oh right. I guess the build farm would use the oldest kernel headers for this 
I.e. the replacement code would be built as long as appropriate kernel headers
were installed.  This may be a gotcha for some build / deployment setups,
but that would be unusual, so this is the right default.
I'm just extra paranoid about ensuring copy routines are robust.

Sorry for the noise.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]