[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fchmodat.c & lchmod.c - O_PATH & AT_EMPTY_PATH on older kernels
|
From: |
Bruno Haible |
|
Subject: |
Re: fchmodat.c & lchmod.c - O_PATH & AT_EMPTY_PATH on older kernels |
|
Date: |
Sun, 12 Jun 2022 17:03:27 +0200 |
Paul Eggert wrote:
> Also, now that I'm
> thinking about it, the Gnulib code didn't work if fstatat fails with
> EOVERFLOW and should be using readlinkat instead. Please try the first
> attached patch, which I've installed in Gnulib.
The patch works fine on
- Linux
- FreeBSD (both with and without O_PATH), NetBSD, OpenBSD,
- minix 3.3.0
- macOS 10.x
- AIX 7.1
- Solaris 10, 11
- Cygwin 2.9
But it introduces a regression on native Windows (I tested on mingw).
Two tests now fail, that succeeded before yesterday's patch.
FAIL: test-fchmodat
===================
../../gltests/test-fchmodat.c:61: assertion 'errno == ENOTDIR' failed
FAIL test-fchmodat.exe (exit status: 3)
FAIL: test-lchmod
=================
../../gltests/test-lchmod.c:47: assertion 'errno == ENOTDIR' failed
FAIL test-lchmod.exe (exit status: 3)
Do you have a test environment for native Windows, or should I look into this?
Bruno