[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] lib/argp-ba.c: remove #ifdef

From: Guilherme Janczak
Subject: Re: [PATCH v2] lib/argp-ba.c: remove #ifdef
Date: Wed, 6 Jul 2022 04:09:21 +0000

On Tue, Jul 05, 2022 at 09:21:54PM -0500, Paul Eggert wrote:
> A couple of things. First, this doesn't seem to be glibc patch; it seems to
> be a reverse patch.
> Second, these days, why not just initialize to a null pointer all the time?

I think there's some confusion here. My patch is intended for gnulib, it
removes the #ifdef. Your diff is functionally the same as the v2. By "I
intend to send this to glibc" I mean sending glibc a separate patch that
makes glibc source match the patched gnulib.

I'm trying to create a version of argp in the glibc tree that comes as
close as possible to working everywhere unmodified. All the downstreams
(uClibc-ng, gnulib, argp-standalone) differ from glibc in places they
don't have to, someone just has to send the patches to all the projects
to make them the same. In this case, gnulib has the only argp-ba.c that
doesn't match glibc because gnulib added workaround for a Mac OS bug and
I don't think the current workaround with the #ifdef should go upstream,
so I'm sending gnulib a different solution that I believe could be
commited upstream.
The benefits of getting rid of differences should be apparent: everyone
gets more testers, and rebasing the downstreams on the latest glibc
becomes easier.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]