|
From: | Paul Eggert |
Subject: | Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux |
Date: | Sun, 30 Oct 2022 11:36:44 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 |
On 2022-10-28 07:33, Ondrej Valousek wrote:
2. The 'acl' package (as of today) only supports Posix ACLs and not the NFSv4 style. And besides, we do not use it anyway on modern Linux distros - see the code, instead of calling acl library, we just call getxattr() function directly.
Is that the best we can do? Surely we shouldn't expect user code to contain gems like this:
u_int32_t num_aces = (u_int32_t)ntohl(*((u_int32_t*)(xattr))); /* Grab the number of aces in the acl
Wouldn't it be better to put this sort of thing into a library with a well-defined API (you can call it "nfsacl" if you like) and have Gnulib use that library? Gnulib is supposed to be a portability library, not a packet sniffer.
[Prev in Thread] | Current Thread | [Next in Thread] |