bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] test-getlogin: pacify gcc -Wshadow


From: Paul Eggert
Subject: [PATCH 1/2] test-getlogin: pacify gcc -Wshadow
Date: Sun, 30 Oct 2022 13:26:04 -0700

* tests/test-getlogin.h (test_getlogin_result): Rename local.
---
 ChangeLog             |  5 +++++
 tests/test-getlogin.h | 10 +++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f410dbe048..159bb007ca 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2022-10-30  Paul Eggert  <eggert@cs.ucla.edu>
+
+       test-getlogin: pacify gcc -Wshadow
+       * tests/test-getlogin.h (test_getlogin_result): Rename local.
+
 2022-10-25  Simon Josefsson  <simon@josefsson.org>
 
        gendocs: Output timestamp in English.
diff --git a/tests/test-getlogin.h b/tests/test-getlogin.h
index 94cbc61823..564aea9d09 100644
--- a/tests/test-getlogin.h
+++ b/tests/test-getlogin.h
@@ -58,14 +58,14 @@ test_getlogin_result (const char *buf, int err)
       FILE *fp = fopen ("/proc/self/loginuid", "r");
       if (fp != NULL)
         {
-          char buf[21];
-          size_t n = fread (buf, 1, sizeof buf, fp);
-          if (n > 0 && n < sizeof buf)
+          char fread_buf[21];
+          size_t n = fread (fread_buf, 1, sizeof fread_buf, fp);
+          if (n > 0 && n < sizeof fread_buf)
             {
-              buf[n] = '\0';
+              fread_buf[n] = '\0';
               errno = 0;
               char *endptr;
-              unsigned long value = strtoul (buf, &endptr, 10);
+              unsigned long value = strtoul (fread_buf, &endptr, 10);
               if (*endptr == '\0' && errno == 0)
                 loginuid_undefined = ((uid_t) value == (uid_t)(-1));
             }
-- 
2.37.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]