[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux
From: |
Ondrej Valousek |
Subject: |
RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux |
Date: |
Wed, 16 Nov 2022 09:51:46 +0000 |
> I'm not really sure what to do about ACE4_READ_NAMED_ATTRS and
> ACE4_WRITE_NAMED_ATTRS; those are not the same as Linux extended attributes.
> This will need a bit of testing against various NFSv4 servers to give
> reasonable results.
Can we just commit the code as-is without the extra mask checks for now?
Frankly speaking:
- I still do not understand why we should be doing it, I perceive it as an
unnecessary extra potentially fragile code
- the existing code just "works" well to me. Tried various scenarios on Netapp
and Linux NFS server. It just works.
- I understand it might not be perfect, but I think even you will agree that
it's far better than what we have now in there (i.e. nothing)
- since most of the heavy lifting has already been done, we can patch the masks
later on (if needed) as it should be fairly easy job once we know exactly what
to do there.
I am happy to incorporate the other suggestions you had (thanks for them), but
I have reached the point that I can't invest more time into it.
Thanks,
Ondrej
- [PATCH] Basic support for checking NFSv4 ACLs in Linux, (continued)
- [PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/09
- RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/11
- [PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/14
- Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Andreas Grünbacher, 2022/11/14
- RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/15
- Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Andreas Grünbacher, 2022/11/15
- Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Andreas Grünbacher, 2022/11/15
- RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/15
- Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Andreas Grünbacher, 2022/11/15
- RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux,
Ondrej Valousek <=
Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux, Paul Eggert, 2022/11/14
[PATCH] Basic support for checking NFSv4 ACLs in Linux, Ondrej Valousek, 2022/11/24