[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PROPOSED 4/4] explicit_bzero: implement via memset_explicit
|
From: |
Bruno Haible |
|
Subject: |
Re: [PROPOSED 4/4] explicit_bzero: implement via memset_explicit |
|
Date: |
Tue, 29 Nov 2022 09:09:03 +0100 |
Paul Eggert wrote:
> Thanks for the detailed review. I installed the patches with corrections
> that I hope addressed all your comments.
Thanks Paul. Very nice!
> > I don't understand the purpose of this line:
> > memset (checkbuf, i, SECRET_SIZE);
> > Wouldn't it be better to have
> > memcpy (stbuf, SECRET, SECRET_SIZE);
> > instead?
>
> I added the latter call but kept the former
Perfect. Indeed, I misread the proposed code. Sorry.
Bruno