RE: [PATCH] Basic support for checking NFSv4 ACLs in Linux

[Ondrej Valousek]

Thanks Paul,
I was actually wondering why did not you reuse the suggestion from Andreas:
#  define ROUNDUP(x, y)                  (((x) + (y) - 1) & - (y))
As it seemed to work pretty well to me (+ it makes obvious what we do here).
Anyhow, my 2 cents 😊

-----Original Message-----
From: Paul Eggert <eggert@cs.ucla.edu> 
Sent: středa 28. prosince 2022 5:13
To: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Cc: Gnulib bugs <bug-gnulib@gnu.org>
Subject: Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux

Some static checking helped find an off-by-one bug that I introduced to your 
Gnulib patch. The bug caused file_has_acl to sometimes incorrectly return -1 
when given a nontrivial ACL in which a WHOLEN is a multiple of 4. Sorry about 
that. I installed the attached further patch to fix it.