bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use xattr (Linux) in copy-acl.c


From: Bruno Haible
Subject: Re: [PATCH] Use xattr (Linux) in copy-acl.c
Date: Tue, 03 Jan 2023 21:53:37 +0100

Paul Eggert wrote:
> > +static int
> > +copy_attr_permissions (const char *name, struct error_context *ctx)
> > +{
> > +   int action = attr_copy_action (name, ctx);
> > +   return action == ATTR_ACTION_PERMISSIONS;
> > +}
> 
> 
> This returns bool not int, so it should be declared to return bool.

Nope. This function is used as a callback for attr_copy_file and
attr_copy_fd [1] and therefore needs 'int' as return type.

Bruno

[1] 
https://git.savannah.nongnu.org/gitweb/?p=attr.git;a=blob;f=include/libattr.h;hb=HEAD#l27






reply via email to

[Prev in Thread] Current Thread [Next in Thread]