Re: backupfile and backup-rename are introducing the same object to make

[(GalaxyMaster)]

Bruno,

On Wed, Jan 25, 2023 at 08:44:34PM +0100, Bruno Haible wrote:
> Btw, if we have a problem here, we also have it in other places.
> The .c files that are listed in lib_SOURCES of more than one module are:
> 
>       2 backupfile.c
>       2 pipe-filter-aux.c

With pipe-filter-aux.c I experienced a different issue.  In comparison to all
other modules that work with nonintr_close(), nonintr_open(), nonintr_read(),
and nonintr_write(), this module defines the function as just "inlined", while
execute and spawn-pipe modules declares them as static.  So, to build
pipe-filter-aux as a shareable object I redefined "PIPE_FILTER_AUX_INLINE" to
be "static _GL_INLINE" instead of just "_GL_INLINE" and this basically resolved
the issue.  I think this change may be considered for the inclusion into the
library since I see no reason why every other module is declaring these
functions as static and pipe-filter-aux.c is not.  But again, my use case is
non-standard and is likely not supported :).

-- 
(GM)