bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix: NSTextView.m, -setSelectedRange:...


From: Adam Fedor
Subject: Re: Fix: NSTextView.m, -setSelectedRange:...
Date: Sun, 19 Aug 2001 17:29:46 -0600
User-agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:0.9.2) Gecko/20010630

Georg Fleischmann wrote:


Your fix does it right.
However, the first part of my patch is still needed. It prevents [NSTextView setSelectedRange...] from asking a text storage of zero length for attributes. In this case, the text storage will always return an empty dictionary, thus setting the attributes of the text view to zero.
On OpenStep, asking a zero text storage for attributes would raise an exception.
Here is the shortened patch:



I applied this, since Nicola's out of town. The reasoning seems right, but I'll have to just believe you since I really don't know this code well. Perhaps Nicola can check it when he gets back.



--
Adam Fedor, Digital Optics            | Fudd's law of opposition: Push
fedor@doc.com  http://www.doc.com     | something hard enough, and it
fedor@gnu.org  http://www.gnustep.org | will fall over.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]