Re: two bugs while building back on mingw

[Fred Kiefer]

Nicola Pero wrote

> Can I ask one question then - is 'BUILD_libgnustep_gui_DLL' and
> 'libgnustep_gui_DLL' a general standard for building unix stuff on
> Windows, or is it more or less a gnustep-only trick ?
>
> Because if it's a gnustep-only trick, we could modify it in the following
> way:
>
>
> #if GNUSTEP_WITH_DLL
>
> #if BUILD_libgnustep_gui_DLL
> #  define APPKIT_EXPORT  __declspec(dllexport)
> #  define APPKIT_DECLARE __declspec(dllexport)
> #else
> #  define APPKIT_EXPORT  extern __declspec(dllimport)
> #  define APPKIT_DECLARE __declspec(dllimport)
> #endif
>
> #else # GNUSTEP_WITH[OUT]_DLL
>
> #  define APPKIT_EXPORT extern
> #  define APPKIT_DECLARE
>
> #endif

Although this is a generally used trick, this should be the right way to 
resolve it, as we cannot be sure if the libraries we are including use 
it exactly the same way. So we should only try to control what we can 
control and that is the compilation of our own libraries. And yes this 
trick should do it.

Fred