Re: Panel focus problem

[Enrico Sersale]

On Fri, 18 Oct 2002, Adam Fedor wrote:

> Enrico Sersale wrote:
> >
> > After these changes, I'm getting some focus problems with GWorkspace.
> > The problem consists in a "focus loop" (I don't know how to define
> > exactly this in English) between the app main window and the
> > app menu.
> > If I do a file operation, for example I want to delete a file, an alert
> > panels shows to get confirmation from the user. When this panel closes,
> > the menu and the window get alternately the focus until I click on the
> > window.
> >
>
> Stefan Böhringer wrote:
>  > On a fresh CVS snapshot the key window is deactivated when I click and
>  > release on the main menu, which should not be the case.
>  > Is it a matter of the Window Manager (WindowMaker 0.80)?
>
>
> I fixed these problems, but not in the way I would like.  I'd like to
> have the app icon get focus (as a last resort) when there are no other
> key windows, but some focus interaction with WindowMaker prevented me
> from doing this - It seems like when the app icon is the only key
> window, WindowMaker will spuriously unfocus it (and sometimes this will
> cause a wierd focus look that Enrico describes). WindowMaker doesn't
> treat the app icon the same as other windows so perhaps this is why.
>
> Instead I let the main menu be key, but in most cases it will only
> become key as a last resort - if there are no other possible key windows.
>
> Try to test it and let me know of any issues. You can try
>
> openapp MyApp.app --GNU-Debug=Focus
>
> to see what's going on with the Focus mechanism.

This doesn't fix my focus loop problem. Here is a trace:

click on a gworkspace window:

2002-10-20 13:02:36.855 GWorkspace[10428] Setting focus to 37
2002-10-20 13:02:36.867 GWorkspace[10428] Focus already set on 37
2002-10-20 13:02:36.935 GWorkspace[10428] 16777375 got focus on 37
2002-10-20 13:02:36.936 GWorkspace[10428] take focus:2 (current=37 key=37)
2002-10-20 13:02:36.936 GWorkspace[10428] take focus:37 (current=37
key=37)

click on a icon and start of the drag:

2002-10-20 13:03:29.159 GWorkspace[10428] take focus:67 (current=37
key=37)

the icon is dropped on an other icon and an alert panel is shown:

2002-10-20 13:05:54.476 GWorkspace[10428] take focus:37 (current=37
key=37)
2002-10-20 13:05:54.502 GWorkspace[10428] Setting focus to 70
2002-10-20 13:05:54.503 GWorkspace[10428] Setting focus to 70
2002-10-20 13:05:54.562 GWorkspace[10428] Setting focus to 70
2002-10-20 13:05:54.563 GWorkspace[10428] take focus:70 (current=37
key=70)
2002-10-20 13:05:54.575 GWorkspace[10428] Focus went to 0x8618608
2002-10-20 13:05:54.576 GWorkspace[10428] 16777375 lost focus on 37
2002-10-20 13:05:54.576 GWorkspace[10428] 16777493 got focus on 70

after a click on the ok button the loop starts:

2002-10-20 13:09:43.918 GWorkspace[10428] Setting focus to 70
2002-10-20 13:09:51.046 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:51.374 GWorkspace[10428] Focus went to (null)
2002-10-20 13:09:51.382 GWorkspace[10428] 16777493 lost focus on 70
2002-10-20 13:09:51.393 GWorkspace[10428] take focus:37 (current=70 key=0)
2002-10-20 13:09:51.393 GWorkspace[10428]   but desired focus is 1
2002-10-20 13:09:51.407 GWorkspace[10428] Setting focus to 37
2002-10-20 13:09:51.428 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:51.437 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:51.666 GWorkspace[10428] 16777375 got focus on 37
2002-10-20 13:09:51.667 GWorkspace[10428] take focus:2 (current=37 key=1)
2002-10-20 13:09:51.669 GWorkspace[10428]   but desired focus is 1
2002-10-20 13:09:51.670 GWorkspace[10428] Focus went to (null)
2002-10-20 13:09:51.677 GWorkspace[10428] 16777375 lost focus on 37
2002-10-20 13:09:51.680 GWorkspace[10428] take focus:2 (current=37 key=0)
2002-10-20 13:09:51.685 GWorkspace[10428] take focus:37 (current=37 key=0)

* HERE !! *

2002-10-20 13:09:51.686 GWorkspace[10428] WM take focus on hidden window 2
2002-10-20 13:09:51.696 GWorkspace[10428] Setting focus to 37
2002-10-20 13:09:51.865 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:51.876 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:52.306 GWorkspace[10428] 16777375 got focus on 37
2002-10-20 13:09:52.307 GWorkspace[10428] take focus:2 (current=37 key=1)
2002-10-20 13:09:52.307 GWorkspace[10428]   but desired focus is 1
2002-10-20 13:09:52.310 GWorkspace[10428] Focus went to (null)
2002-10-20 13:09:52.316 GWorkspace[10428] 16777375 lost focus on 37
2002-10-20 13:09:52.317 GWorkspace[10428] take focus:2 (current=37 key=0)
2002-10-20 13:09:52.324 GWorkspace[10428] take focus:37 (current=37 key=0)

2002-10-20 13:09:52.325 GWorkspace[10428] WM take focus on hidden window 2
2002-10-20 13:09:52.346 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:52.357 GWorkspace[10428] Setting focus to 1
2002-10-20 13:09:52.370 GWorkspace[10428] Setting focus to 37
2002-10-20 13:09:52.576 GWorkspace[10428] take focus:2 (current=37 key=37)
2002-10-20 13:09:52.577 GWorkspace[10428]   but desired focus is 37
2002-10-20 13:09:52.577 GWorkspace[10428] take focus:2 (current=37 key=37)
2002-10-20 13:09:52.577 GWorkspace[10428] 16777375 got focus on 37
2002-10-20 13:09:52.577 GWorkspace[10428] take focus:37 (current=37
key=37)

...