Re: Memory leak

[Alexander Malmberg]

Nicola Pero wrote:
> 
> > > Andy,
> > >
> > > have you tried using gnustep-gui's memory panel ?
> > >
> > I made the memory panel show in the test cases.
> 
> Great
> 
> > There is nothing unusual.
> 
> Argh :-)
> 
> Thanks - I'll have a look at it myself at some point if nobody else does.
> 
> Let us know if you find any more detail. :-)

I've tested with the new text system, and it shows up with back-xlib but
not back-art. I've tracked it down (or at least one leak) to XGFontInfo.
-setupAttributes is using XLoadQueryFont() to load the font and
XFontStruct, but -dealloc is using XUnloadFont(), which frees the font
but not the XFontStruct. Using XFreeFont() instead fixes it. I've
attached a patch.

- Alexander Malmberg

Index: xlib/XGFont.m
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/back/Source/xlib/XGFont.m,v
retrieving revision 1.6.2.1
diff -u -r1.6.2.1 XGFont.m
--- xlib/XGFont.m       26 Nov 2002 12:00:54 -0000      1.6.2.1
+++ xlib/XGFont.m       20 Jan 2003 19:47:41 -0000
@@ -126,7 +126,7 @@
 - (void) dealloc
 {
   if (font_info != NULL)
-    XUnloadFont([XGServer currentXDisplay], font_info->fid);
+    XFreeFont([XGServer currentXDisplay], font_info);
   [super dealloc];
 }