Re[2]: MD5

[Manuel Guesdon]

Hi,

On Thu, 23 Jan 2003 12:44:59 +0100 David Ayers <d.ayers@inode.at> wrote:
 >| I don't think the issue right now is "how" to implement it (because with 
 >| yours we now seem to have three implementations) but rather "where".  
 >| But let me get back to "how" anyway.  I think the following API would be 
 >| usefull
 >| 
 >| @interface NSData (MD5)
 >| - (NSData *)md5Digest; /* This method actually implements the calculations*/

seems good.


 >| - (NSString *)md5StringUsingEncoding: (NSStringEncoding) enc;

MD5 strings are usually encoded as done in GSCryptBase.m: DataToHexString (be 
carefill to checkout last version .There
was a bug on previous versions).
There's no need for encoding. so I'll prefer using name like: 
md5DigestHexString.

 >| - (NSString *)md5String; /* uses default encoding.*/

==> md5DigestHexString.

 >| @end
 >| 
 >| @interface NSString (MD5)
 >| - (NSString *)md5StringUsingEncoding: (NSStringEncoding) enc;

==> md5DigestHexString.

 >| - (NSString *)md5String; /* uses default encoding.*/

==> md5DigestHexString.

 >| @end

 >| But more importantly is where these Categories should go:
 >| 
 >| 1. base/Additions

base/Additions seems a good place. 
MD5 is also used by Pantomime so adding this in base/Additons would make it 
available 
for gsweb & Pantomime without having to add another library or copying code.

 >| 2. gscrypt - well actually I wouldn't change the existing 
 >| implementation, I would just try handling the pam_-problem transparently 
 >| with LIBRARY_DEPENDS_UPON or/and configure.

The best way I see for this is to add a configure so pam part can be ignored.

Manuel
--
______________________________________________________________________
Manuel Guesdon - ORANGE CONCEPT <mguesdon@orange-concept.com>
14 rue Jean-Baptiste Clement  -  93200 Saint-Denis  -  France
Tel: +33 1 4940 0997  -  Fax: +33 1 4940 0998