Re: NSMenuView and popups (was: Re: [PATCH] Menus in lowerleft corner)

[Willem Rein Oudshoorn]

Michael Hanni <michael@deviant-behavior.com> writes:

> Hi Willem,
> 
> --- Willem Rein Oudshoorn <woudshoo@xs4all.nl> wrote:
> 
> In testing this I came across a small issue in the popup buttons which was the
> result not of this patch but your previous NSMenuView work. It seems that even
> popupbuttons have an NSMenuViewWindowTitle (off the top of my head I can't
> remember the name) assigned to them... Thus, if you manipulate a popup like 
> the
> several in GWorkspace you get some weird behavior. If the popup needs more 
> than
> a split second to complete its action you get a weird size/resize shuffle with
> a titlebar.

I have fixed this in my version.  I will make a patch combining this, 
with your suggestion of delaying the sizeToFit and Serg Stoyan 
Close button fix.  

Afterwards someone can commit it.

> Since the NSMenuViewWindowTitleBar-thingie is created in NSMenuView's
> initWithFrame, and the NSMenu creating the NSMenuView doesn't know its owned 
> by
> a popup until right after its init, we are slightly screwed. I suppose we 
> could
> catch this on the first sizeToFit in NSMenuView -- like we catch the left
> offset?
>
actually I did this in the update method.


Wim Oudshoorn.