bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RFA: [base] NSKeyValueCoding fix ivar search order


From: David Ayers
Subject: RFA: [base] NSKeyValueCoding fix ivar search order
Date: Wed, 26 Mar 2003 00:24:52 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210

Hello Richard,

Setting up the (still uncommited) tests for GDL2 I noticed that the search order for ivars differs from what WO4.5 does. I take it that OS X takeValue:forKey: should first check the actual key as an ivar before it checks _key.

      * Source/NSKeyValueCoding.m ([NSObject -takeValue:forKey:]):
      Corrected search order of instance variables.

OK to commit?

Cheers,
Dave

? core/base/SSL/SSL.bundle
? core/base/SSL/config.log
? core/base/SSL/config.mak
? core/base/SSL/config.status
? core/base/SSL/ix86
? core/base/SSL/shared_obj
? core/base/Source/Additions/shared_obj
? core/base/Tools/make_strings/shared_obj
Index: core/base/ChangeLog
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/base/ChangeLog,v
retrieving revision 1.1789
diff -u -r1.1789 ChangeLog
--- core/base/ChangeLog 25 Mar 2003 18:02:14 -0000      1.1789
+++ core/base/ChangeLog 25 Mar 2003 23:13:00 -0000
@@ -8,6 +8,8 @@
        
 2003-03-25  David Ayers  <d.ayers@inode.at>
 
+       * Source/NSKeyValueCoding.m ([NSObject -takeValue:forKey:]): 
+       Corrected search order of instance variables.
        * Headers/gnustep/base/GSObjCRuntime.h
        * Source/Additions/GSObjCRuntime.m (GSObjCGetMethod),
        (GSObjCReplaceMethod): Added new functions. 
Index: core/base/Source/NSKeyValueCoding.m
===================================================================
RCS file: /cvsroot/gnustep/gnustep/core/base/Source/NSKeyValueCoding.m,v
retrieving revision 1.6
diff -u -r1.6 NSKeyValueCoding.m
--- core/base/Source/NSKeyValueCoding.m 23 Mar 2003 07:06:27 -0000      1.6
+++ core/base/Source/NSKeyValueCoding.m 25 Mar 2003 23:13:00 -0000
@@ -295,10 +295,10 @@
                  buf[size+4] = '\0';
                  buf[3] = '_';
                  buf[4] = lo;
-                 name = &buf[3];       // _key
+                 name = &buf[4];       // key
                  if (GSObjCFindVariable(self, name, &type, &size, &off) == NO)
                    {
-                     name = &buf[4];   // key
+                     name = &buf[3];   // _key
                      GSObjCFindVariable(self, name, &type, &size, &off);
                    }
                }

reply via email to

[Prev in Thread] Current Thread [Next in Thread]