Re: Bugs in GDL2/EOAccess/EODatabaseContext.m

[David Ayers]

Stéphane Corthésy wrote:

> Hi,
>
> Three bugs in gdl2/EOAccess/EODatabaseContext.m:
>
> - in setDelegate:, the == in the while loop must be replaced by a 
> single = 

Thanks!

> - in -relayPrimaryKey:object:entity:, the test if(isToMany) must be 
> done only if value != nil 

This sounds sane, but I think I'll have to look into the implementation 
a bit more, to see what the circumstances are in which the relationship 
doesn't exist.

> - in -_fireArrayFault:, the call [EOFault clearFault: object] must be 
> replaced by [object self], because it may happen that object is not a 
> fault, thus the call would raise; invoking self instead clears the 
> fault if it is one 

I'll also have to look closer into this, to see if _fireArrayFault: (or 
rather  EO(Access)FaultHandler completeInitializationOfObject:) should 
be legaly be called with a non-fault-object at all.  Not that we are 
covering up a but in another area.

Cheers,
Dave