Re: [RFA/base] NSUndoManager cleanup

[Adam Fedor]

On Monday, July 14, 2003, at 03:02 AM, David Ayers wrote:
> +/** Defines run loop ordering for closing undo groupings. */
> +enum {
> +  NSUndoCloseGroupingRunLoopOrdering = 350000
> +};
> +

Wow documentation! I'd approve it just for that :-)

>  /* Public notification */
>  GS_EXPORT NSString *NSUndoManagerCheckpointNotification;
>  GS_EXPORT NSString *NSUndoManagerDidOpenUndoGroupNotification;
> @@ -44,14 +49,13 @@
>  @private
>      NSMutableArray     *_redoStack;
>      NSMutableArray     *_undoStack;
> -    NSString           *_actionName;

I sort-of hate to remove ivars unnecessarily, due to the (small) 
incompatibility it creates between different library versions. Perhaps 
just replace it by _unused1? I don't think an extra ivar adds that much 
memory...

Everything else seems fine.