|
From: | Fred Kiefer |
Subject: | Re: Full unicode support for back-xlib (2) |
Date: | Thu, 17 Jul 2003 11:47:27 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204 |
Hi Kazu, this patch looks great! There a only a few things I would like to change:- As XGFontSetEnumerator is currently not implemented I would remove all reverences to it.
- [initWithFontName:matrix:screenFont:] may lead to memory leaks as RELEASE(self) is missing for all the error cases.
- char_struct_for_glyph() could return a boolean value if the chracter was found. Thereby making all the calls, especially [glyphIsEncoded:] a lot simple and removing the need of memset() inside this function.
- My man pages warn about the use of the funtion strtok(). Why not pass into load_font_set() the NSString and use [componentsSeparatedByString:] (This method is also use in the font_chacher.m)? In this part of the code I am also a bit unsure about the pieces of the XLFD that you use and the ones you discard. Could you explain, document what you do and why? (For example, I would use the family and discard the foundry, you do the opposit)
- What we could also think of is to make the switch between your and the standard implementation of font handling one at runtime. Allowing for a simpler transistion without recompiling the backend each time. See the user default for the use of the XFT fonts.
Cheers Fred Kazunobu Kuriyama wrote:
Based on Fred Kiefer's suggestion, I rewrote the patches I previously sent to bug-gnustep with the email 'Full unicode support for back-xlib'. A few bug fixes have also been done. While the functionality the new patches offer remains the same as thatof the previous ones, both the organization and the performance are improved.The main differences are: (1) The part that was included in XGSFont.m.patch becomes two new files, XGFontSetFontInfo.h and XGFontSetFontInfo.m. (2) The new module resulting from these files is used in XGContext.m. As a result, the new module can be handled similarly to those of XGFont.m and GSXftFontInfo.m.
[Prev in Thread] | Current Thread | [Next in Thread] |