Re: [RFC] NSTabView* rewrite (patch)

[Adam Fedor]

On Friday, July 25, 2003, at 08:36 PM, Michael Hanni wrote:

> Hi,
>
> I've completely rewritten my previous rewrite of these two classes. 
> The result
> is a much better implementation of both, including such things as: all 
> tab view
> types are supported; re-sizable tabs and view; better handling of 
> tabviewitems;
> works in Gorm; documentation; and many other things. In fact there 
> have been so
> many changes and additions I can barely remember everything.
>
> There are still a few things to implement: NSPressedTab; finalize the
> appearance of the tabs in all directions; and, most critically, the
> initWithCoder code.
>
> I'd appreciate comments regarding this code -- especially with regard 
> to memory
> management and the NSCoder bits.

Looks pretty good, although I haven't had time to really look at it.

@@ -132,6 +193,8 @@

 - (NSArray*) tabViewItems
 {
+  // FIXME: should this be a copy? or?
+
   return (NSArray*)_items;
 }

This could use the base method:

return [_items makeImmutableCopyOnFail: YES];