Re: focus problems [PATCH]

[Adam Fedor]

On Wed, 2003-10-15 at 11:32, Benhur Stein wrote:
> Hi!
> The attached patches solve most of the focus problems I have with 
> GNUstep.
> 
> ______________________________________________________________________
Focus problems are my nemesis so perhaps I can ask a few questions. I
need to try to document all the problems and what's been tried to fix
them


>+++ Source/x11/XGServerEvent.m  15 Oct 2003 17:10:45 -0000
>@@ -528,6 +528,8 @@
>                          number = generic.currentFocusWindow;
>                        [self setinputstate: GSTitleBarKey : number];
>                        [self setinputfocus: number];
>+                       generic.focusRequestNumber = 0;
>+                       generic.desiredFocusWindow = 0;

Why does this cause a problem for you? You can read the comment above
this in the source about some of the problems this solves, although
there are others it solves as well.

 +++ Source/NSApplication.m      15 Oct 2003 17:17:59 -0000
@@ -949,8 +949,13 @@
        }
       else if ([self mainWindow] != nil)
        {
-         [[self mainWindow] orderFront: self];
+         [[self mainWindow] makeKeyAndOrderFront: self];
        }

Why this? We don't really want to make the main window key unless it is
supposed to be?

+      else
+        {
+         //FIXME: why doesn't this work?
+          [[[self mainMenu] window] makeKeyAndOrderFront:self];
+        }
 
Did this not work before?  It works for me - WindowMaker tries to give
windows keyboard focus and the main menu should accept it (That's a
hack, but it should work, see the WindowFocus documentation in
back/Documentation/Back).