NSMenu menu position saving bug (PATCH)

[Michael Hanni]

Hi there,

The menu position saving code has not worked for me for quite awhile. 
After being prodded by Alex I chased this bug down. Attached is a 
patch. Basically the problem is with this code:

return [NSString stringWithFormat: @"\033%@", [self title]]; 
//NSMenu.m ~155

On my machine this would return, for the Info menu, "nfo" not 
"\033Info", so the key was always nil (interestingly enough, if I 
manually edited the key in the defaults to be \033Info it worked 
properly). I changed this to:

return [NSString stringWithFormat: @"+%@", [self title]];

and the key was saved and read correctly.

I'm not sure if this is the proper fix, but it works here.

Cheers,

Michael

<nsmenu-bug.patch>

nsmenu-bug.patch
Description: Text Data