Re: NSUser.m: Bug on Windows handling spaces in environement variable values?

[David Ayers]

Adam Fedor wrote:

> Any comments on this patch?
>
> Incidently, make/user_home.c seems to have a bug:
>
> diff -u -r1.13 user_home.c
> --- user_home.c 30 Nov 2003 10:18:46 -0000      1.13
> +++ user_home.c 18 Feb 2004 16:43:11 -0000
> @@ -204,9 +204,9 @@
>  
>        for (i = 0; i < strlen(home); i++)
>         {
> -         if (isspace((int)home[0]))
> +         if (isspace((int)home[i]))

This seems correct.

>             {
> -             home[0] = '\0';   /* Spaces not permitted! */
> +             home[i] = '\0';   /* Spaces not permitted! */

This seems fishy... I haven't looked closer, but this seems to just 
ignore the "rest" of the string and interpret the first part as the home 
directory.

>               break;
>             }

Cheers,
David