Re: NSUser.m: Bug on Windows handling spaces in environement variable values?

[Sheldon Gill]

----------  Forwarded Message  ----------

Subject: Re: NSUser.m: Bug on Windows handling spaces in environement variable 
values?
Date: Tue, 3 Feb 2004 10:37
From: Sheldon Gill <sheldon@iinet.net.au>
To: discuss-gnustep@gnu.org
Cc: Roland Schwingel <roland.schwingel@onevision.de>

On Mon, 2 Feb 2004 21:14, Roland Schwingel wrote:
> Hi...
>
> Maybe there is a bug in NSUser.m.
> In CVS revision 1.75 there was a changed added to not permit spaces in
> $USERPROFILE.
> Why was it added?

This is a bug that I've fixed in my sources.  The behaviour was (I believe)
there to match the behaviour in gnustep-make but that's not necessary in
gnustep-base.

It's in gnustep-make because 'make' doesn't handle spaces in paths and
filenames.

My modifications to gnustep-make changes this behaviour to issue a clear
warning rather than fail entirely.


Regards,
Sheldon


_______________________________________________
Discuss-gnustep mailing list
Discuss-gnustep@gnu.org
http://mail.gnu.org/mailman/listinfo/discuss-gnustep

-------------------------------------------------------
IMHO:

There shouldn't be a check for spaces in the path for -base.

There should be a check for spaces in the path for -make to issue an advisory 
warning that it may cause problems because 'make' is unable to handle such 
paths correctly.

My mods are in accordance with this. For -make the relevant part is

------------------------------------------------------------------------------
  /*
   * Get the home directory.
   */
  if (get_home_directory(loginName,home,2048))
    {
      int       i;

      for (i = 0; i < strlen(home); i++)
        {
          if (isspace((unsigned int)home[i]))
            {
              /*
               * GNU make doesn't handle spaces in paths.
               * Broken, wrong and totally unfixable.
               */
              fprintf(stderr, "Make cannot handle spaces in paths so the " \
                          "home directory '%s' may cause problems!\n", home);
            }
        }
    }
  else
    {
      fprintf(stderr, "Unable to locate home directory for '%s'\n", 
loginName);
      return 1;
    }
------------------------------------------------------------------------------