Re: [PATCH] NSButtonCell

[Gregory John Casamento]

--- Quentin_Mathé <gnustep-quentin@club-internet.fr> wrote:
> 
> Le 24 févr. 04, à 12:55, Fred Kiefer a écrit :
> 
> > Adam Fedor wrote:
> >> On Thu, 2004-02-05 at 08:00, Quentin Mathé wrote:
> >>> Here is a patch for NSButtonCell.m which permits to the class to be 
> >>> drawn transparent when it is not bordered.
> >>>
> >>> I also removed few lines about the focus dotted rect in order to 
> >>> have it always drawn with the same size than the button. It looks 
> >>> inconsistent to me to have the dotted rect not drawn with the same 
> >>> size when the button has a title, IMHO it should indicate the last 
> >>> focused area which in this case is not just the title area, but like 
> >>> always the button area. And I think also the focus dotted rect must 
> >>> be drawn even when the button is not bezeled (nor bordered).
> >>> What do you think ?
> >>>
> >> Looks reasonable to me. Any other comments on this?
> >
> > I thought, that due to my drawing patch for NSButtonCell this patch 
> > was no longer needed. Am I wrong here?
> 
> Yes I think your NSButtonCell modifications are unrelated, because your 
> patch reworks the button border drawing... and the one I send just want 
> to add support for non opaque buttons.
> 
> > We rather ask Quentin before we make any further change. Apart from 
> > that, I would join Gregory and clain that the way this patch handles 
> > things is not fully correct.
> 
> Here you are right, my patch wa as hack and was not the right way to 
> fix the thing. I send a better patch to Gregory (for NSToolbar support) 
> and here it is :
> 

> ATTACHMENT part 2 application/octet-stream x-unix-mode=0644;
name=NSButtonCell.m.patch
> 
> 
> This patch also improves the text placement for the non bordered 
> buttons. With this patch, text unlike images have a margin in a non 
> bordered button in order to improve the default look and to facilitate 
> the developer work.
> 
> bye,
> Quentin

Quentin,

This seems to produce the same effect as before in Gorm and other apps which
use NSMatrix.

Thanks, GJC


=====
Gregory John Casamento -- CEO/President Open Logic Corp.

__________________________________
Do you Yahoo!?
Yahoo! Mail SpamGuard - Read only the mail you want.
http://antispam.yahoo.com/tools